[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <30e2487e-5738-46bc-95f7-8d0ba3ba9b1a@suse.com>
Date: Tue, 13 Jan 2026 10:49:16 +0100
From: Oliver Neukum <oneukum@...e.com>
To: weipeng <coderlogicwei@...il.com>,
syzbot+30b78308ba7e64647ff8@...kaller.appspotmail.com
Cc: anna-maria@...utronix.de, frederic@...nel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
syzkaller-bugs@...glegroups.com, tglx@...utronix.de
Subject: Re: [syzbot] [usb?] INFO: task hung in i2c_tiny_usb_disconnect
On 13.01.26 08:52, weipeng wrote:
> @@ -287,9 +311,9 @@ static void i2c_tiny_usb_disconnect(struct usb_interface *interface)
> {
> struct i2c_tiny_usb *dev = usb_get_intfdata(interface);
>
> - i2c_del_adapter(&dev->adapter);
> usb_set_intfdata(interface, NULL);
> - i2c_tiny_usb_free(dev);
> + WRITE_ONCE(dev->disconnected, true);
> + queue_work(system_long_wq, &dev->release_work);
Hi,
I am sorry, but this fix is looking a bit fishy.
For once what prevents the driver from being unloaded
with a work item queued after disconnect() has run?
How do you make sure that the disconnected flag is ever read?
Regards
Oliver
Powered by blists - more mailing lists