linux-kernel - Re: [PATCH] greybus: Use bus methods for .probe() and .remove()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWYZM-c1XcvD6LPw@hovoldconsulting.com>
Date: Tue, 13 Jan 2026 11:06:43 +0100
From: Johan Hovold <johan@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus: Use bus methods for .probe() and .remove()

On Wed, Dec 10, 2025 at 06:59:39PM +0100, Uwe Kleine-König wrote:
> These are nearly identical to the respective driver callbacks. The only
> difference is that .remove() returns void instead of int.
> 
> The objective is to get rid of users of struct device_driver callbacks
> .probe() and .remove() to eventually remove these.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
 
> -const struct bus_type greybus_bus_type = {
> -	.name =		"greybus",
> -	.match =	greybus_match_device,
> -	.uevent =	greybus_uevent,
> -	.shutdown =	greybus_shutdown,
> -};
> -
 
> +const struct bus_type greybus_bus_type = {
> +	.name = "greybus",
> +	.match = greybus_match_device,
> +	.uevent = greybus_uevent,
> +	.probe = greybus_probe,
> +	.remove = greybus_remove,
> +	.shutdown = greybus_shutdown,
> +};
> +

Please keep the indentation style when moving the struct.

With that addressed:

Acked-by: Johan Hovold <johan@...nel.org>

Johan