[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3be5b6a7-3b26-4899-8313-c849c28300ca@sirena.org.uk>
Date: Wed, 14 Jan 2026 18:48:34 +0000
From: Mark Brown <broonie@...nel.org>
To: Fuad Tabba <tabba@...gle.com>
Cc: Marc Zyngier <maz@...nel.org>, Joey Gouly <joey.gouly@....com>,
Catalin Marinas <catalin.marinas@....com>,
Suzuki K Poulose <suzuki.poulose@....com>,
Will Deacon <will@...nel.org>, Paolo Bonzini <pbonzini@...hat.com>,
Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
Oliver Upton <oupton@...nel.org>, Dave Martin <Dave.Martin@....com>,
Mark Rutland <mark.rutland@....com>,
Ben Horgan <ben.horgan@....com>,
linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
Peter Maydell <peter.maydell@...aro.org>,
Eric Auger <eric.auger@...hat.com>
Subject: Re: [PATCH v9 26/30] KVM: arm64: Provide interface for configuring
and enabling SME for guests
On Tue, Jan 13, 2026 at 02:40:58PM +0000, Fuad Tabba wrote:
> On Tue, 23 Dec 2025 at 01:23, Mark Brown <broonie@...nel.org> wrote:
> > Due to the overlap with sizing the SVE state we finalise both SVE and
> > SME with a single finalization, preventing any further changes to the
> > SVE and SME configuration once KVM_ARM_VCPU_VEC (an alias for _VCPU_SVE)
> > has been finalised. This is not a thing of great elegance but it ensures
> With KVM_ARM_VCPU_VEC being an alias for KVM_ARM_VCPU_SVE, wouldn't
> kvm_arm_vcpu_finalize() fail for guests that have only SME enabled but
> not SVE?
If one of the extensions hasn't been enabled then the goal is that
finalizing should lock in the current state and prevent enabling it in
future but you should be able to finalize. The check for vcpu_has_sve()
which blocks finialization is changed to vcpu_has_vec() which is true if
either SVE or SME is enabled.
We should, however, ensure that the VL of disabled vector types isn't
taken into account when allocating state in order to avoid wasting
memory - I'll update for that.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists