| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<PS1PPF62EEA9B1D69C7BC1FA44FB41EFF68AE8FA@PS1PPF62EEA9B1D.apcprd03.prod.outlook.com>
Date: Wed, 14 Jan 2026 03:58:10 +0000
From: Nick Xie <nick@...das.com>
To: Jerome Brunet <jbrunet@...libre.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman
<khilman@...libre.com>, Martin Blumenstingl
<martin.blumenstingl@...glemail.com>, Xianwei Zhao <xianwei.zhao@...ogic.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-amlogic@...ts.infradead.org"
<linux-amlogic@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject:
回复: [PATCH 2/2] arm64: dts: amlogic: s4: fix mmc clock assignment
Hello Jerome,
I checked this patch on Amlogic S4 S905Y4, the eMMC & SDIO card also works.
root@...das:~# uname -a
Linux Khadas 6.19.0-rc5+ #26 SMP PREEMPT Tue Jan 13 16:01:18 CST 2026 aarch64 aarch64 aarch64 GNU/Linux
root@...das:~# dmesg | grep mmc
[ 0.301186] meson-gx-mmc fe08a000.mmc: Got CD GPIO
[ 0.302028] meson-gx-mmc fe08c000.mmc: allocated mmc-pwrseq
[ 0.392252] mmc1: new UHS-I speed SDR104 SDHC card at address aaaa
[ 0.393414] mmcblk1: mmc1:aaaa SP32G 29.7 GiB
[ 0.395724] mmcblk1: p1 p2
[ 0.473691] mmc0: new HS200 MMC card at address 0001
[ 0.474417] mmcblk0: mmc0:0001 AJTD4R 14.6 GiB
[ 0.475852] mmcblk0: p1 p2
[ 0.476413] mmcblk0boot0: mmc0:0001 AJTD4R 4.00 MiB
[ 0.478143] mmcblk0boot1: mmc0:0001 AJTD4R 4.00 MiB
[ 0.479716] mmcblk0rpmb: mmc0:0001 AJTD4R 4.00 MiB, chardev (239:0)
[ 3.243664] EXT4-fs (mmcblk1p2): mounted filesystem 43b6881a-483c-4ca7-9dcd-f4575e665a8b r/w with writeback data mode. Quota mode: none.
[ 4.706154] EXT4-fs (mmcblk1p2): re-mounted 43b6881a-483c-4ca7-9dcd-f4575e665a8b.
[ 5.900986] EXT4-fs (mmcblk1p1): mounted filesystem f20cabae-bbc6-457e-9bb3-bac6eef01af5 r/w with ordered data mode. Quota mode: none.
[ 6.283608] meson-gx-mmc fe088000.mmc: allocated mmc-pwrseq
[ 6.484310] mmc2: new UHS-I speed SDR104 SDIO card at address 0001
Tested-by: Nick Xie <nick@...das.com>
Best Regards
Nick
________________________________________
发件人: Jerome Brunet <jbrunet@...libre.com>
已发送: 2026 年 1 月 13 日 星期二 18:39
收件人: Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Neil Armstrong <neil.armstrong@...aro.org>; Kevin Hilman <khilman@...libre.com>; Martin Blumenstingl <martin.blumenstingl@...glemail.com>; Xianwei Zhao <xianwei.zhao@...ogic.com>; Nick Xie <nick@...das.com>
抄送: devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org <linux-arm-kernel@...ts.infradead.org>; linux-amlogic@...ts.infradead.org <linux-amlogic@...ts.infradead.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; Jerome Brunet <jbrunet@...libre.com>
主题: [PATCH 2/2] arm64: dts: amlogic: s4: fix mmc clock assignment
MMC A and C are mis-represented as having their "clkin0" input connected to
xtal while it is actually connected to the MMC clock, mostly in an attempt
to provide 24MHz to the device on this input.
Fix this and assign the clock to 24MHz to actually provide the required
rate.
Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4")
Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
---
arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index 62538fd9db6b1ffb33a88e12628aadefbaa453ec..6324d1eb5994009df5b09923cce373a87229f4b8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -819,13 +819,17 @@ sdio: mmc@...88000 {
reg = <0x0 0xfe088000 0x0 0x800>;
interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clkc_periphs CLKID_SDEMMC_A>,
- <&xtal>,
+ <&clkc_periphs CLKID_SD_EMMC_A>,
<&clkc_pll CLKID_FCLK_DIV2>;
clock-names = "core", "clkin0", "clkin1";
resets = <&reset RESET_SD_EMMC_A>;
cap-sdio-irq;
keep-power-in-suspend;
status = "disabled";
+
+ assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_A>;
+ assigned-clock-parents = <0>;
+ assigned-clock-rates = <24000000>;
};
sd: mmc@...8a000 {
@@ -849,13 +853,17 @@ emmc: mmc@...8c000 {
reg = <0x0 0xfe08c000 0x0 0x800>;
interrupts = <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>;
clocks = <&clkc_periphs CLKID_NAND>,
- <&xtal>,
+ <&clkc_periphs CLKID_SD_EMMC_C>,
<&clkc_pll CLKID_FCLK_DIV2>;
clock-names = "core", "clkin0", "clkin1";
resets = <&reset RESET_NAND_EMMC>;
no-sdio;
no-sd;
status = "disabled";
+
+ assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_C>;
+ assigned-clock-parents = <0>;
+ assigned-clock-rates = <24000000>;
};
};
};
--
2.47.3
Powered by blists - more mailing lists