| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a09feb0e-6736-49a9-aba1-799174c9b43a@linaro.org>
Date: Wed, 14 Jan 2026 10:05:33 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Chuan Liu <chuan.liu@...ogic.com>, Jerome Brunet <jbrunet@...libre.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Kevin Hilman <khilman@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Xianwei Zhao <xianwei.zhao@...ogic.com>, Nick Xie <nick@...das.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: amlogic: s4: fix mmc clock assignment
On 1/14/26 03:48, Chuan Liu wrote:
> hi Jerome,
>
> On 1/13/2026 6:39 PM, Jerome Brunet wrote:
>> [ EXTERNAL EMAIL ]
>>
>> MMC A and C are mis-represented as having their "clkin0" input connected to
>> xtal while it is actually connected to the MMC clock, mostly in an attempt
>> to provide 24MHz to the device on this input.
>
> Right.
>
>>
>> Fix this and assign the clock to 24MHz to actually provide the required
>> rate.
>>
>> Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4")
>> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> index 62538fd9db6b1ffb33a88e12628aadefbaa453ec..6324d1eb5994009df5b09923cce373a87229f4b8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
>> @@ -819,13 +819,17 @@ sdio: mmc@...88000 {
>> reg = <0x0 0xfe088000 0x0 0x800>;
>> interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clkc_periphs CLKID_SDEMMC_A>,
>> - <&xtal>,
>> + <&clkc_periphs CLKID_SD_EMMC_A>,
>> <&clkc_pll CLKID_FCLK_DIV2>;
>> clock-names = "core", "clkin0", "clkin1";
>> resets = <&reset RESET_SD_EMMC_A>;
>> cap-sdio-irq;
>> keep-power-in-suspend;
>> status = "disabled";
>> +
>> + assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_A>;
>> + assigned-clock-parents = <0>;
>
> Is it possible to remove assigned-clock-parent?
Yes it's not necessary to keep it.
Neil
>
>> + assigned-clock-rates = <24000000>;
>> };
>>
>> sd: mmc@...8a000 {
>> @@ -849,13 +853,17 @@ emmc: mmc@...8c000 {
>> reg = <0x0 0xfe08c000 0x0 0x800>;
>> interrupts = <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>;
>> clocks = <&clkc_periphs CLKID_NAND>,
>> - <&xtal>,
>> + <&clkc_periphs CLKID_SD_EMMC_C>,
>> <&clkc_pll CLKID_FCLK_DIV2>;
>> clock-names = "core", "clkin0", "clkin1";
>> resets = <&reset RESET_NAND_EMMC>;
>> no-sdio;
>> no-sd;
>> status = "disabled";
>> +
>> + assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_C>;
>> + assigned-clock-parents = <0>;
>> + assigned-clock-rates = <24000000>;
>> };
>> };
>> };
>>
>> --
>> 2.47.3
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
Powered by blists - more mailing lists