linux-kernel - Re: [PATCH] mm/khugepaged: make khugepaged_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10ebbce4-1b83-4eb2-99f3-738a0e613958@arm.com>
Date: Wed, 14 Jan 2026 10:50:19 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-mm@...ck.org
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
 david@...nel.org, lorenzo.stoakes@...cle.com
Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static

On 12/01/26 9:48 PM, Ben Dooks wrote:
> Make khugepaged_collapse_control as it is not exported.
> Fixes the following sparse warning:
> 
> mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?
> 
> Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
>  mm/khugepaged.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 97d1b2824386..c9bd0df632bd 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
>  	remove_wait_queue(&khugepaged_wait, &wait);
>  }
>  
> -struct collapse_control khugepaged_collapse_control = {
> +static struct collapse_control khugepaged_collapse_control = {
>  	.is_khugepaged = true,
>  };
>  

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>