linux-kernel - Re: [PATCH] mm/khugepaged: make khugepaged_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ade8187-87ca-4f04-8c65-1d27acc001d9@lucifer.local>
Date: Wed, 14 Jan 2026 09:27:48 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Anshuman Khandual <anshuman.khandual@....com>
Cc: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        david@...nel.org
Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static

Andrew - just to avoid confusion - this patch should be ignored, is an
accidentally sent duplicate and was already sent by a previous submitter
see [0].

Cheers, Lorenzo

On Wed, Jan 14, 2026 at 10:50:19AM +0530, Anshuman Khandual wrote:
> On 12/01/26 9:48 PM, Ben Dooks wrote:
> > Make khugepaged_collapse_control as it is not exported.
> > Fixes the following sparse warning:
> >
> > mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?
> >
> > Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
> > Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> > ---
> >  mm/khugepaged.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> > index 97d1b2824386..c9bd0df632bd 100644
> > --- a/mm/khugepaged.c
> > +++ b/mm/khugepaged.c
> > @@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
> >  	remove_wait_queue(&khugepaged_wait, &wait);
> >  }
> >
> > -struct collapse_control khugepaged_collapse_control = {
> > +static struct collapse_control khugepaged_collapse_control = {
> >  	.is_khugepaged = true,
> >  };
> >
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

[0]: https://lore.kernel.org/linux-mm/49229782-acf5-4e33-b317-63399deb6f6d@lucifer.local/