linux-kernel - Re: [PATCH v4 1/6] dt-bindings: gpio-mmio: Add opencores GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114-agile-kangaroo-of-honor-963dc6@quoll>
Date: Wed, 14 Jan 2026 09:31:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stafford Horne <shorne@...il.com>
Cc: Bartosz Golaszewski <brgl@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Linux OpenRISC <linux-openrisc@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linusw@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: gpio-mmio: Add opencores GPIO

On Tue, Jan 13, 2026 at 04:31:33PM +0000, Stafford Horne wrote:
> On Tue, Jan 13, 2026 at 05:20:28PM +0100, Bartosz Golaszewski wrote:
> > On Tue, Jan 13, 2026 at 5:15 PM Stafford Horne <shorne@...il.com> wrote:
> > >
> > > Add a device tree binding for the opencores GPIO controller.
> > >
> > > On FPGA Development boards with GPIOs the OpenRISC architecture uses the
> > > opencores gpio verilog rtl which is compatible with the MMIO GPIO driver.
> > >
> > > Link: https://opencores.org/projects/gpio
> > > Signed-off-by: Stafford Horne <shorne@...il.com>
> > > Reviewed-by: Linus Walleij <linusw@...nel.org>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > ---
> > > Since v3:
> > >  - Removed example.
> > >  - Re-order this patch to be before adding compatible string to driver as per
> > >    device tree binding patch rules.
> > >  - Add Reviewed-by's.
> > > Since v2:
> > >  - Fixup (replace) patch to simply add opencores,gpio and add an example.
> > >    (It was incorrect to specifying opencores,gpio with brcm,bcm6345-gpio
> > >     as opencores,gpio is not the same hardware, its 8-bit vs 32-bit)
> > > Since v1:
> > >  - Fix schema to actually match the example.
> > >
> > >  Documentation/devicetree/bindings/gpio/gpio-mmio.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > > index ee5d5d25ae82..a8823ca65e78 100644
> > > --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > > +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> > > @@ -23,6 +23,7 @@ properties:
> > >        - ni,169445-nand-gpio
> > >        - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> > >        - intel,ixp4xx-expansion-bus-mmio-gpio
> > > +      - opencores,gpio
> > >
> > >    big-endian: true
> > >
> > > --
> > > 2.51.0
> > >
> > 
> > This is not a follow-up patch. Please rebase your fix on top of
> > linux-next. I already have the previous patch in my tree and will not
> > be rebasing the entire for-next branch.
> 
> OK, understood, I wasn't aware you would not rebase. I will rework this rebasing
> on linux-next reberting my previous dt-binding: patch first.

No, you need to rebase, not revert.

Best regards,
Krzysztof