linux-kernel - Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114-slick-passionate-mink-216a3a@quoll>
Date: Wed, 14 Jan 2026 09:51:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nick Xie <xieqinick@...il.com>
Cc: neil.armstrong@...aro.org, khilman@...libre.com, jbrunet@...libre.com, 
	martin.blumenstingl@...glemail.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, xianwei.zhao@...ogic.com, 
	christianshewitt@...il.com, krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, 
	nick@...das.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S
 binding

On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> Add devicetree binding for Khadas VIM1S board based on
> Amlogic S4 S905Y4 SoC.
> 
> Signed-off-by: Nick Xie <nick@...das.com>

You still have the same From/SoB mismatch.

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 08d9963fe9259..55663e0f7f915 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -247,6 +247,12 @@ properties:
>                - amlogic,aq222
>            - const: amlogic,s4
>  
> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> +        items:
> +          - enum:

Yopu already have exactly such enum with such description, so your
compatible goes there. Look - it is called "Boards" - plural.

> +              - khadas,vim1s
> +          - const: amlogic,s4

Best regards,
Krzysztof