linux-kernel - Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP4nuTXeC1-6ktwLpDt_1ZRHxPSiNAoDKTxLzqEYJUfcnVogcQ@mail.gmail.com>
Date: Wed, 14 Jan 2026 18:07:05 +0800
From: Nick Xie <xieqinick@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: neil.armstrong@...aro.org, khilman@...libre.com, jbrunet@...libre.com, 
	martin.blumenstingl@...glemail.com, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-amlogic@...ts.infradead.org, xianwei.zhao@...ogic.com, 
	christianshewitt@...il.com, krzk+dt@...nel.org, robh@...nel.org, 
	conor+dt@...nel.org, nick@...das.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Krzysztof Kozlowski <krzk@...nel.org> 于2026年1月14日周三 16:51写道：
>
> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> > Add devicetree binding for Khadas VIM1S board based on
> > Amlogic S4 S905Y4 SoC.
> >
> > Signed-off-by: Nick Xie <nick@...das.com>
>
> You still have the same From/SoB mismatch.

OK,  I will fix it in next version.

>
> > ---
> >  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > index 08d9963fe9259..55663e0f7f915 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > @@ -247,6 +247,12 @@ properties:
> >                - amlogic,aq222
> >            - const: amlogic,s4
> >
> > +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> > +        items:
> > +          - enum:
>
> Yopu already have exactly such enum with such description, so your
> compatible goes there. Look - it is called "Boards" - plural.

The exist board aq222 is based on SoC S905X2, but the new board vim1s
is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

>
> > +              - khadas,vim1s
> > +          - const: amlogic,s4
>
> Best regards,
> Krzysztof
>