linux-kernel - RE: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB94967965CFD39EE3642615C9908CA@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Thu, 15 Jan 2026 11:51:54 +0000
From: Bough Chen <haibo.chen@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Han Xu <han.xu@....com>, Mark Brown <broonie@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 2026年1月15日 17:39
> To: Bough Chen <haibo.chen@....com>
> Cc: Han Xu <han.xu@....com>; Mark Brown <broonie@...nel.org>; Rob
> Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor
> Dooley <conor+dt@...nel.org>; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>;
> linux-spi@...r.kernel.org; imx@...ts.linux.dev; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
> 
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> >  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index
> >
> a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13
> a32
> > 65315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> >      oneOf:
> >        - enum:
> >            - nxp,imx94-xspi
> > +      - items:
> > +          - enum:
> > +              - nxp,imx952-xspi
> > +          - const: nxp,imx94-xspi
> 
> You never checked your DTS and broke all existing users. And existing tools
> would clearly tell you that if you tried.
> 
> Use tools instead of reviewers. Reviewers time is more important, so if you just
> disregard it I find it quite disrespectful.

Hi Krzysztof,

I did run dt binding check before I send out this patch.
I list the log in the following, no error report.
Can you help point out where I have to improve?

nxa12937@...inux89:~/linux-next$ make64 distclean
  CLEAN   Documentation/devicetree/bindings
  CLEAN   scripts/basic
  CLEAN   scripts/dtc
  CLEAN   scripts/kconfig
  CLEAN   include/config include/generated .config
nxa12937@...inux89:~/linux-next$ make64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  CHKDT   ./Documentation/devicetree/bindings
  LINT    ./Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dts
  DTC [C] Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dtb

Regards
Haibo Chen
> 
> Best regards,
> Krzysztof