linux-kernel - Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWkEnEJRj01JSZj5@lizhi-Precision-Tower-5810>
Date: Thu, 15 Jan 2026 10:15:40 -0500
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Haibo Chen <haibo.chen@....com>, Han Xu <han.xu@....com>,
	Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-spi@...r.kernel.org,
	imx@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi

On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> >  Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> >      oneOf:
> >        - enum:
> >            - nxp,imx94-xspi
> > +      - items:
> > +          - enum:
> > +              - nxp,imx952-xspi
> > +          - const: nxp,imx94-xspi
>
> You never checked your DTS and broke all existing users. And existing
> tools would clearly tell you that if you tried.

Krzysztof:

	what's wrong?

	I have not find any warnings under arch/arm64/boot/dts/freescale by

	make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs

Frank
>
> Use tools instead of reviewers. Reviewers time is more important, so if
> you just disregard it I find it quite disrespectful.
>
> Best regards,
> Krzysztof
>