linux-kernel - Re: [PATCH v3 2/3] Input: ili210x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUd9TNWixxEYjEdOVLoR982tn4jgZXEnWKhnUTObYXuZQ@mail.gmail.com>
Date: Thu, 15 Jan 2026 17:21:36 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: linux-input@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Frank Li <Frank.Li@....com>, 
	Job Noorman <job@...rman.info>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 2/3] Input: ili210x - convert to dev_err_probe()

Hi Marek,

On Thu, 15 Jan 2026 at 17:19, Marek Vasut
<marek.vasut+renesas@...lbox.org> wrote:
> Simplify error return handling, use dev_err_probe() where possible.
> No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>

Thanks for your patch!

> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -942,15 +942,11 @@ static int ili210x_i2c_probe(struct i2c_client *client)
>         chip = device_get_match_data(dev);
>         if (!chip && id)
>                 chip = (const struct ili2xxx_chip *)id->driver_data;
> -       if (!chip) {
> -               dev_err(&client->dev, "unknown device model\n");
> -               return -ENODEV;
> -       }
> +       if (!chip)
> +               return dev_err_probe(&client->dev, -ENODEV, "unknown device model\n");
>
> -       if (client->irq <= 0) {
> -               dev_err(dev, "No IRQ!\n");
> -               return -EINVAL;
> -       }
> +       if (client->irq <= 0)
> +               dev_err_probe(dev, -EINVAL, "No IRQ!\n");

Missing return.


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds