linux-kernel - Re: [PATCH 2/2] drm/bridge: waveshare-dsi: Add support for 1..4 DSI data lanes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b029410-d960-42a8-9d2a-e731234598fe@mailbox.org>
Date: Thu, 15 Jan 2026 03:47:35 +0100
From: Marek Vasut <marek.vasut@...lbox.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: dri-devel@...ts.freedesktop.org, Andrzej Hajda <andrzej.hajda@...el.com>,
 Conor Dooley <conor+dt@...nel.org>, David Airlie <airlied@...il.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jonas Karlman <jonas@...boo.se>,
 Joseph Guo <qijian.guo@....com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, Rob Herring <robh@...nel.org>,
 Robert Foss <rfoss@...nel.org>, Simona Vetter <simona@...ll.ch>,
 Thomas Zimmermann <tzimmermann@...e.de>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/bridge: waveshare-dsi: Add support for 1..4 DSI
 data lanes

On 1/14/26 10:32 AM, Geert Uytterhoeven wrote:

Hello Geert,

>> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> @@ -66,7 +66,11 @@ static int ws_bridge_attach_dsi(struct ws_bridge *ws)
>>          dsi->mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
>>                            MIPI_DSI_CLOCK_NON_CONTINUOUS;
>>          dsi->format = MIPI_DSI_FMT_RGB888;
>> -       dsi->lanes = 2;
>> +       dsi->lanes = drm_of_get_data_lanes_count_ep(dev->of_node, 0, 0, 1, 4);
>> +       if (dsi->lanes < 0) {
>> +               dev_warn(dev, "Invalid DSI lane count %d, falling back to 2 lanes\n", dsi->lanes);
> 
> "Invalid or missing"?

Fixed in V2

> BTW, I doubt the kerneldoc for drm_of_get_data_lanes_count_ep()
> is correct:
Nice find, fixed in

[PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value 
documentation

Thanks !