linux-kernel - Re: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1adf54a9-56f5-4fc4-bba2-837a132fd123@sirena.org.uk>
Date: Thu, 15 Jan 2026 18:02:15 +0000
From: Mark Brown <broonie@...nel.org>
To: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
Cc: clg@...d.org, boris.brezillon@...tlin.com, joel@....id.au,
	andrew@...econstruct.com.au, linux-aspeed@...ts.ozlabs.org,
	openbmc@...ts.ozlabs.org, linux-spi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	BMC-SW@...eedtech.com
Subject: Re: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

On Thu, Jan 15, 2026 at 11:04:54PM +0800, Chin-Ting Kuo wrote:

> +static int aspeed_spi_user_transfer(struct spi_controller *ctlr,
> +				    struct spi_message *msg)
> +{

I'm not seeing anything here that won't work with transfer_one() rather
than transfer_one_message(), that would reduce open coding so if you can
do it it's preferable.

> +	ctrl_val = chip->ctl_val[ASPEED_SPI_BASE];
> +	ctrl_val &= ~CTRL_IO_MODE_MASK & data->hclk_mask;
> +	ctrl_val |= clk_div;
> +	chip->ctl_val[ASPEED_SPI_BASE] = ctrl_val;

This should fit with the prepare_message() callback.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)