linux-kernel - RE: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB5203DC69FD31B7550F86DE3FB28AA@TYZPR06MB5203.apcprd06.prod.outlook.com>
Date: Sat, 17 Jan 2026 04:48:18 +0000
From: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
To: Mark Brown <broonie@...nel.org>
CC: "clg@...d.org" <clg@...d.org>, "boris.brezillon@...tlin.com"
	<boris.brezillon@...tlin.com>, "joel@....id.au" <joel@....id.au>,
	"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
	"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
	"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Friday, January 16, 2026 2:02 AM
> Subject: Re: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices
> 
> On Thu, Jan 15, 2026 at 11:04:54PM +0800, Chin-Ting Kuo wrote:
> 
> > +static int aspeed_spi_user_transfer(struct spi_controller *ctlr,
> > +				    struct spi_message *msg)
> > +{
> 
> I'm not seeing anything here that won't work with transfer_one() rather than
> transfer_one_message(), that would reduce open coding so if you can do it it's
> preferable.
> 

Okay, I will change the implementation to transfer_one() in the next patch version.

> > +	ctrl_val = chip->ctl_val[ASPEED_SPI_BASE];
> > +	ctrl_val &= ~CTRL_IO_MODE_MASK & data->hclk_mask;
> > +	ctrl_val |= clk_div;
> > +	chip->ctl_val[ASPEED_SPI_BASE] = ctrl_val;
> 
> This should fit with the prepare_message() callback.

Okay, prepare_message() and unprepare_message() callback functions will be created in the next patch version.


Chin-Ting