linux-kernel - Re: [PATCH 3/3] mm/hugetlb: Enforce brace style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0760613-5c57-4f04-848b-a0a6ff05c0e8@kernel.org>
Date: Thu, 15 Jan 2026 21:10:41 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Joshua Hahn <joshua.hahnjy@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Muchun Song <muchun.song@...ux.dev>, Oscar Salvador <osalvador@...e.de>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 3/3] mm/hugetlb: Enforce brace style

On 1/15/26 19:14, Joshua Hahn wrote:
> Documentation/process/coding-style.rst explicitly notes that if only one
> branch of a conditional statement is a single statement, braces should
> be used in both branches. Enforce this in mm/hugetlb.c.
> 
> No functional change intended.
> 
> Signed-off-by: Joshua Hahn <joshua.hahnjy@...il.com>
> ---

[...]

>   		update_and_free_hugetlb_folio(h, folio, false);
>   		return rc;
> @@ -2672,11 +2675,13 @@ void restore_reserve_on_error(struct hstate *h, struct vm_area_struct *vma,
>   				 * be consumed on a subsequent allocation.
>   				 */
>   				folio_set_hugetlb_restore_reserve(folio);
> -		} else
> +		} else {
>   			/*
>   			 * No reservation present, do nothing
>   			 */
>   			 vma_end_reservation(h, vma, address);
> +

But why the empty line? :)

> +		}
>   	}
>   }



-- 
Cheers

David