linux-kernel - Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260115201108.1028113-1-joshua.hahnjy@gmail.com>
Date: Thu, 15 Jan 2026 15:11:07 -0500
From: Joshua Hahn <joshua.hahnjy@...il.com>
To: Joshua Hahn <joshua.hahnjy@...il.com>
Cc: Manish Kumar <manish1588@...il.com>,
	akpm@...ux-foundation.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c

On Thu, 15 Jan 2026 15:07:52 -0500 Joshua Hahn <joshua.hahnjy@...il.com> wrote:

> On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <manish1588@...il.com> wrote:
> 
> > Change the declaration of 'seq' from 'unsigned' to 'unsigned int'
> > to follow kernel coding style. No functional change.
> > 
> > Signed-off-by: Manish Kumar <manish1588@...il.com>
> 
> Hello Manish, I hope you're doing well!
> 
> The patch looks good to me. However, I just have a few comments about the
> other patches that you've recently sent out as well.
> 
> I think it could be very helpful for reviewers, if you grouped related commits
> together (in this case, mm/page_alloc.c cleanups) into a single patchset.
> This lets the reviewers view all related commits together, in each others'
> contexts.
> 
> It would also be super helpful to Cc some of the reviewers / maintainers who
> are relevant to the change you are making! scripts/get_maintainer.pl will
> give you a good idea of who might be people who are expereinced in the area
> and are willing to review the patch.
> 
> Thank you for the patchset, have a great day!
> 
> Reviewed-by: Joshua Hahn <joshua.hahnjy@...il.com>

Whoops, one more thing. The deletion of an empty tab is included in this patch,
but it's not mentioned at all in the changelog. Before adding my reviewed-by,
please elaborate on it in the changelog, or submit it in a separate patch.