linux-kernel - Re: [PATCH V2 3/5] mm/khugepaged: change collapse_pte_mapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <719f9bcd-0990-48e7-bf3b-929417a13db5@kernel.org>
Date: Fri, 16 Jan 2026 00:48:48 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Shivank Garg <shivankg@....com>, Andrew Morton
 <akpm@...ux-foundation.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Zi Yan <ziy@...dia.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Nico Pache
 <npache@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
 Dev Jain <dev.jain@....com>, Barry Song <baohua@...nel.org>,
 Lance Yang <lance.yang@...ux.dev>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to
 return void

On 12/24/25 12:13, Shivank Garg wrote:
> The only external caller of collapse_pte_mapped_thp() is uprobe, which
> ignores the return value. Change the external API to return void to
> simplify the interface.
> 
> Introduce try_collapse_pte_mapped_thp() for internal use that preserves
> the return value. This prepares for future patch that will convert
> the return type to use enum scan_result.
> 
> Suggested-by: David Hildenbrand (Red Hat) <david@...nel.org>
> Signed-off-by: Shivank Garg <shivankg@....com>
> ---
>   include/linux/khugepaged.h |  9 ++++-----
>   mm/khugepaged.c            | 40 ++++++++++++++++++++++----------------
>   2 files changed, 27 insertions(+), 22 deletions(-)
> 
> diff --git a/include/linux/khugepaged.h b/include/linux/khugepaged.h
> index eb1946a70cff..37b992b22bba 100644
> --- a/include/linux/khugepaged.h
> +++ b/include/linux/khugepaged.h
> @@ -17,8 +17,8 @@ extern void khugepaged_enter_vma(struct vm_area_struct *vma,
>   				 vm_flags_t vm_flags);
>   extern void khugepaged_min_free_kbytes_update(void);
>   extern bool current_is_khugepaged(void);
> -extern int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr,
> -				   bool install_pmd);
> +extern void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr,
> +				    bool install_pmd);

Sorry for late review.

We remove the "extern" whenever we touch functions.

Nit: two tab indent on second parameter line. Same applies for the other 
code you touch below (if you already adjust that line, just indent with 
two tabs).

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David