linux-kernel - Re: [PATCH V2 4/5] mm/khugepaged: use enum scan_result for result variables and return types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d9019a0-8427-466c-a8da-b373562c4566@kernel.org>
Date: Fri, 16 Jan 2026 00:51:17 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Shivank Garg <shivankg@....com>, Andrew Morton
 <akpm@...ux-foundation.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Zi Yan <ziy@...dia.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Nico Pache
 <npache@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
 Dev Jain <dev.jain@....com>, Barry Song <baohua@...nel.org>,
 Lance Yang <lance.yang@...ux.dev>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 4/5] mm/khugepaged: use enum scan_result for result
 variables and return types

On 12/24/25 12:13, Shivank Garg wrote:
> Convert result variables and return types from int to enum scan_result
> throughout khugepaged code. This improves type safety and code clarity
> by making the intent explicit.
> 
> No functional change.
> 
> Signed-off-by: Shivank Garg <shivankg@....com>
> ---
>   mm/khugepaged.c | 111 +++++++++++++++++++++++++-----------------------
>   1 file changed, 57 insertions(+), 54 deletions(-)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 04ff0730c9a1..6892b23d6fc4 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -537,17 +537,18 @@ static void release_pte_pages(pte_t *pte, pte_t *_pte,
>   	}
>   }
>   
> -static int __collapse_huge_page_isolate(struct vm_area_struct *vma,
> -					unsigned long start_addr,
> -					pte_t *pte,
> -					struct collapse_control *cc,
> -					struct list_head *compound_pagelist)
> +static enum scan_result __collapse_huge_page_isolate(struct vm_area_struct *vma,
> +						     unsigned long start_addr,
> +						     pte_t *pte,
> +						     struct collapse_control *cc,
> +						     struct list_head *compound_pagelist)

Another reason to use to tabs to indent.

(Again, applies to all cases where you touch the lines either way :) )

-- 
Cheers

David