linux-kernel - Re: [PATCH v2] x86/mm: Hide mm_free_global_asid() definition under 'CONFIG_BROADCAST_TLB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260115091506.GAaWiwGnvRTOOUVGtv@fat_crate.local>
Date: Thu, 15 Jan 2026 10:15:06 +0100
From: Borislav Petkov <bp@...en8.de>
To: Hou Wenlong <houwenlong.hwl@...group.com>
Cc: linux-kernel@...r.kernel.org, Rik van Riel <riel@...riel.com>,
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Will Deacon <will@...nel.org>, Ryan Roberts <ryan.roberts@....com>,
	Jann Horn <jannh@...gle.com>, Barry Song <baohua@...nel.org>
Subject: Re: [PATCH v2] x86/mm: Hide mm_free_global_asid() definition under
 'CONFIG_BROADCAST_TLB_FLUSH'

On Thu, Jan 15, 2026 at 11:38:34AM +0800, Hou Wenlong wrote:
> When 'CONFIG_BROADCAST_TLB_FLUSH' is not enabled, mm_free_global_asid()
> remains a globally visible symbol and generates a useless function call
> to it in destroy_context(). Therefore, hide the mm_free_global_asid()
> definition under 'CONFIG_BROADCAST_TLB_FLUSH' and provide a static
> inline empty version when it is not enabled to remove the function call.
> 
> Reviewed-by: Rik van Riel <riel@...riel.com>
> Signed-off-by: Hou Wenlong <houwenlong.hwl@...group.com>
> ---
> v1->v2:
> Keep the declarations of mm_init_global_asid() and mm_free_global_asid()
> in 'asm/mmu_context.h' to fix the compilation failure of module
> building.
> ---
>  arch/x86/include/asm/mmu_context.h | 2 --
>  arch/x86/include/asm/tlbflush.h    | 3 +++
>  arch/x86/mm/tlb.c                  | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)

Did you run the build tests I asked you to do before you sent this?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette