linux-kernel - Re: [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q2jjixx6imiwdwlxiu4cnh6nghnueivjge5d4jscor5q6yx2el@lxujpebn3nsx>
Date: Fri, 16 Jan 2026 15:23:56 -0600
From: Andrew Jones <andrew.jones@....qualcomm.com>
To: fangyu.yu@...ux.alibaba.com
Cc: tjeznach@...osinc.com, joro@...tes.org, will@...nel.org,
        robin.murphy@....com, pjw@...nel.org, palmer@...belt.com,
        aou@...s.berkeley.edu, alex@...ti.fr, guoren@...nel.org,
        ajones@...tanamicro.com, iommu@...ts.linux.dev,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries

On Fri, Jan 16, 2026 at 02:12:06PM -0600, Andrew Jones wrote:
...
> > @@ -1055,6 +1135,11 @@ static void riscv_iommu_iodir_update(struct riscv_iommu_device *iommu,
> >  		/* Invalidate device context after update */
> >  		riscv_iommu_cmd_iodir_inval_ddt(&cmd);
> >  		riscv_iommu_cmd_iodir_set_did(&cmd, fwspec->ids[i]);
> > +		/*
> > +		 * For now, the SVA and PASID features have not yet been merged, the
> > +		 * default configuration is inval_pdt=false and pc=NULL.
> > +		 */
> > +		riscv_iommu_iodir_iotinval(iommu, false, dc->iohgatp, dc, NULL);

Shouldn't this iotinval come after the cmd-send below?

> >  		riscv_iommu_cmd_send(iommu, &cmd);
> >  	}
> >  
> > -- 
> > 2.50.1
> >

Thanks,
drew