linux-kernel - Re: Re: [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260117043149.76084-1-fangyu.yu@linux.alibaba.com>
Date: Sat, 17 Jan 2026 12:31:49 +0800
From: fangyu.yu@...ux.alibaba.com
To: andrew.jones@....qualcomm.com
Cc: ajones@...tanamicro.com,
	alex@...ti.fr,
	aou@...s.berkeley.edu,
	fangyu.yu@...ux.alibaba.com,
	guoren@...nel.org,
	iommu@...ts.linux.dev,
	joro@...tes.org,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	palmer@...belt.com,
	pjw@...nel.org,
	robin.murphy@....com,
	tjeznach@...osinc.com,
	will@...nel.org
Subject: Re: Re: [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries 

>On Fri, Jan 16, 2026 at 02:12:06PM -0600, Andrew Jones wrote:
>...
>> > @@ -1055,6 +1135,11 @@ static void riscv_iommu_iodir_update(struct riscv_iommu_device *iommu,
>> >  		/* Invalidate device context after update */
>> >  		riscv_iommu_cmd_iodir_inval_ddt(&cmd);
>> >  		riscv_iommu_cmd_iodir_set_did(&cmd, fwspec->ids[i]);
>> > +		/*
>> > +		 * For now, the SVA and PASID features have not yet been merged, the
>> > +		 * default configuration is inval_pdt=false and pc=NULL.
>> > +		 */
>> > +		riscv_iommu_iodir_iotinval(iommu, false, dc->iohgatp, dc, NULL);
>
>Shouldn't this iotinval come after the cmd-send below?

Yes, that's a typo on my side.
I’ll fix in v2.
>
>> >  		riscv_iommu_cmd_send(iommu, &cmd);
>> >  	}
>> >  
>> > -- 
>> > 2.50.1
>> >
>
>Thanks,
>drew
>
Thanks,
Fangyu