linux-kernel - Re: [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e65bcd0-54c1-41ff-8552-6ed5c56c1f70@kernel.org>
Date: Fri, 16 Jan 2026 09:34:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Peter Rosin <peda@...ntia.se>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Johan Hovold <johan+linaro@...nel.org>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 David Lechner <dlechner@...libre.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] dt-bindings: mux: gpio-mux: add adi,adg2404
 support

On 16/01/2026 09:29, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 02:18:21PM +0200, Antoniu Miclaus wrote:
>> Add adi,adg2404 as a compatible string. The ADG2404 is a 4:1 analog
>> multiplexer that uses the enable-gpios feature.
>>
>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
>> ---
>> changes in v3:
>>  * integrate with gpio-mux bindings instead of separate adi,adg2404.yaml
>> ---
>>  .../devicetree/bindings/mux/gpio-mux.yaml     | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> index 199792d42323..f5866b9f46dd 100644
>> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
>> @@ -19,7 +19,9 @@ description: |+
>>  
>>  properties:
>>    compatible:
>> -    const: gpio-mux
>> +    enum:
>> +      - gpio-mux
>> +      - adi,adg2404
> 
> I do not understand why this was placed in gpio-mux. You have a strictly
> defined hardware, with known muxes, not a flexible semi-software
> binding.
> 
> Otherwise please explain: why do you have both 0 and 1 cells?
> 
> This is supposed to be in its own binding.

After reading further patches - this patch does not make sense, but it
should not be its own binding. Rob at v2 gave you advice what should be
done.

Best regards,
Krzysztof