linux-kernel - Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29f9b3e2-11d9-42a4-add2-64ec73f69e39@kernel.org>
Date: Fri, 16 Jan 2026 09:34:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Peter Rosin <peda@...ntia.se>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Srinivas Kandagatla <srini@...nel.org>,
 Johan Hovold <johan+linaro@...nel.org>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 David Lechner <dlechner@...libre.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] mux: gpio-mux: add adi,adg2404 support

On 16/01/2026 09:32, Krzysztof Kozlowski wrote:
> On Thu, Jan 15, 2026 at 02:18:22PM +0200, Antoniu Miclaus wrote:
>> Add adi,adg2404 to the compatible list. The ADG2404 is a 4:1 analog
>> multiplexer that benefits from the enable GPIO support to prevent
>> glitches during channel transitions.
>>
>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
>> ---
>> changes in v3:
>>  * integrate with gpio-mux driver instead of standalone adg2404 driver
>> ---
>>  drivers/mux/gpio.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
>> index 93487483e81f..bd8f0c617dd6 100644
>> --- a/drivers/mux/gpio.c
>> +++ b/drivers/mux/gpio.c
>> @@ -59,6 +59,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>>  
>>  static const struct of_device_id mux_gpio_dt_ids[] = {
>>  	{ .compatible = "gpio-mux", },
>> +	{ .compatible = "adi,adg2404", },
> 
> Why do you need the compatible? I do not understand this patchset. You
> are saying you integrate it into gpio-mux, but what you did is to
> duplicate the compatible and binding.
> 
> Half of your patches are not necessary, you only needed to add
> enable-gpios to gpio-mux with argument that ADG2404 can use such binding
> (in complete/full/proper way).

... and Rob at v2 asked already that...

Best regards,
Krzysztof