linux-kernel - Re: [PATCH 1/1] net: spacemit: Check netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3659a81b-4393-4a8d-bc8d-6ab89396353d@lunn.ch>
Date: Sun, 18 Jan 2026 17:19:00 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Chukun Pan <amadeus@....edu.cn>
Cc: Vivian Wang <wangruikang@...as.ac.cn>, Yixun Lan <dlan@...too.org>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	spacemit@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: spacemit: Check netif_carrier_ok when reading
 stats

On Sun, Jan 18, 2026 at 06:00:00PM +0800, Chukun Pan wrote:
> Currently, when the interface is not linked up, reading the interface
> stats will print several timeout logs. Add a netif_carrier_ok check to
> the emac_stats_update function to avoid this situation:
> 
> root@...nWrt:~# ubus call network.device status
> [  120.365060] k1_emac cac81000.ethernet eth1: Read stat timeout

What is the real issue here? That a clock is disabled? Can you test
the status of the clock, rather than adding yet more conditions to
this if ()?

     Andrew