linux-kernel - Re: [PATCH 10/11] perf/amd/ibs: Enable streaming store filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41ebf668-36d0-4084-8697-cb856be1de02@amd.com>
Date: Mon, 19 Jan 2026 18:32:41 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
CC: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim
	<namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>, James Clark
	<james.clark@...aro.org>, <x86@...nel.org>,
	<linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Manali
 Shukla" <manali.shukla@....com>, Santosh Shukla <santosh.shukla@....com>,
	Ananth Narayan <ananth.narayan@....com>, Sandipan Das <sandipan.das@....com>,
	Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH 10/11] perf/amd/ibs: Enable streaming store filter

Hi Dapeng,

>> @@ -416,6 +425,15 @@ static int perf_ibs_init(struct perf_event *event)
>>  		hwc->extra_reg.config |= fetchlat << 1;
>>  	}
>>  
>> +	if (perf_ibs_strmst_event(perf_ibs, event)) {
>> +		u64 strmst = event->attr.config1 & IBS_OP_CONFIG1_STRMST_MASK;
>> +
>> +		strmst >>= 12;
> 
> The right shift can be directly merged into previous sentence, and better
> define some macro instead of use these magic numbers.

Ack.

Thanks for the review,
Ravi