linux-kernel - Re: [PATCH] compiler_types: Introduce inline_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <681985ss-q84n-r802-90pq-0837pr1463p5@syhkavp.arg>
Date: Mon, 19 Jan 2026 10:47:51 -0500 (EST)
From: Nicolas Pitre <nico@...xnic.net>
To: David Laight <david.laight.linux@...il.com>
cc: Andrew Morton <akpm@...ux-foundation.org>, 
    Eric Dumazet <edumazet@...gle.com>, 
    linux-kernel <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, 
    Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <eric.dumazet@...il.com>, 
    Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] compiler_types: Introduce inline_for_performance

On Sun, 18 Jan 2026, David Laight wrote:

> On 32bit you probably don't want to inline __arch_xprod_64(), but you do
> want to pass (bias ? m : 0) and may want separate functions for the
> 'no overflow' case (if it is common enough to worry about).

You do want to inline it. Performance quickly degrades otherwise.
Numbers are in the commit log where I introduced that change.

And __arch_xprod_64() exists only for 32bit btw.


Nicolas