linux-kernel - Re: [PATCH] stm class: Fix Kconfig symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260119154606.GE2732125@e132581.arm.com>
Date: Mon, 19 Jan 2026 15:46:06 +0000
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
	linux-kernel@...r.kernel.org,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] stm class: Fix Kconfig symbols

On Mon, Jan 19, 2026 at 12:35:23PM +0000, James Clark wrote:

[...]

> > @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
> >   config STM_PROTO_SYS_T
> >   	tristate "MIPI SyS-T STM framing protocol driver"
> > -	default CONFIG_STM
> > +	default STM
> 
> The help below here says "If you don't know what this is, say N." which
> makes me wonder if this should be on by default or not?

STM_PROTO_BASIC is a must have config when enabling STM.  While
STM_PROTO_SYS_T is not mandatory, but it is useful to build it so that
users can select the protocol dynamically at runtime.

> Also everything is in an "if STM" block, so "default STM" is a bit
> redundant. It's not that obvious what the intention was.

They are two different things.

"if STM" expresses a dependency (the module depends on STM), while
"default STM" means the module will be selected by default if STM is
enabled.

Thanks,
Leo

P.s. I also tried using the "select" and "imply" syntax to enable the
protocol configurations.  Based on testing, I did not observe any
difference compared to using the "default" syntax.