linux-kernel - Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFSOPXFSOUY2.2Z6XCLCD796Q@fairphone.com>
Date: Mon, 19 Jan 2026 16:52:23 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>, "Luca Weiss"
 <luca.weiss@...rphone.com>, "Bjorn Andersson" <andersson@...nel.org>,
 "Konrad Dybcio" <konradybcio@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>
Cc: <~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect
 sensor

On Mon Jan 19, 2026 at 3:41 PM CET, Konrad Dybcio wrote:
> On 1/16/26 3:22 PM, Luca Weiss wrote:
>> Add a node for the Hall Effect sensor, used to detect whether the Flip
>> Cover is closed or not.
>> 
>> The sensor is powered through vreg_l10b, so let's put a
>> regulator-always-on on that to make sure the sensor gets power.
>
> Is there anything else on L10B? Can we turn it off if the hall sensor
> is e.g. user-disabled?

It's the voltage source for pull-up of sensor I2C bus (so
ADSP-managed?), DVDD for amplifiers and VDD for a most sensors like
the gyro.

So realistically, it'll probably be (nearly) always on anyways. And I
don't want to shave another yak by adding vdd support to gpio-keys...

Regards
Luca

>
> Konrad
>
>> 
>> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> index 7629ceddde2a..98b3fc654206 100644
>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
>> @@ -32,6 +32,16 @@ gpio-keys {
>>  		pinctrl-0 = <&volume_up_default>;
>>  		pinctrl-names = "default";
>>  
>> +		/* Powered by the always-on vreg_l10b */
>> +		event-hall-sensor {
>> +			label = "Hall Effect Sensor";
>> +			gpios = <&tlmm 70 GPIO_ACTIVE_LOW>;
>> +			linux,input-type = <EV_SW>;
>> +			linux,code = <SW_LID>;
>> +			linux,can-disable;
>> +			wakeup-source;
>> +		};
>> +
>>  		key-volume-up {
>>  			label = "Volume Up";
>>  			gpios = <&pm7550_gpios 6 GPIO_ACTIVE_LOW>;
>> @@ -316,6 +326,8 @@ vreg_l10b: ldo10 {
>>  			regulator-min-microvolt = <1800000>;
>>  			regulator-max-microvolt = <1800000>;
>>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +			/* Hall sensor VDD */
>> +			regulator-always-on;
>>  		};
>>  
>>  		vreg_l11b: ldo11 {
>> 
>> ---
>> base-commit: ef1c7b875741bef0ff37ae8ab8a9aaf407dc141c
>> change-id: 20260116-fp6-hall-sensor-1049f2f872ac
>> 
>> Best regards,