linux-kernel - Re: [PATCH 25/37] cifs: SMB1 split: Split SMB1 protocol defs into smb1pdu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3895f58-2c70-441b-8975-77c121ee2950@linux.dev>
Date: Mon, 19 Jan 2026 14:51:26 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: David Howells <dhowells@...hat.com>, Steve French <sfrench@...ba.org>
Cc: Paulo Alcantara <pc@...guebit.org>, Enzo Matsumiya <ematsumiya@...e.de>,
 linux-cifs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH 25/37] cifs: SMB1 split: Split SMB1 protocol defs into
 smb1pdu.h

FILE_BASIC_INFO (and possibly other definitions) is also used in 
client/smb2inode.c, and it is defined in MS-FSCC 2.4.7, so perhaps we 
should move these definitions into a new header file client/fscc.h.

Of course, for FILE_BASIC_INFO, smb/server/ has smb2_file_basic_info in 
smb/server, so we could move them into common/fscc.h.

Thanks,
ChenXiaoSong <chenxiaosong@...inos.cn>

On 12/23/25 06:29, David Howells wrote:
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> -typedef struct {
> -	__le64 CreationTime;
> -	__le64 LastAccessTime;
> -	__le64 LastWriteTime;
> -	__le64 ChangeTime;
> -	__le32 Attributes;
> -	__u32 Pad;
> -} __packed FILE_BASIC_INFO;	/* size info, level 0x101 */
> -
> --- /dev/null
> +++ b/fs/smb/client/smb1pdu.h
> +typedef struct {
> +	__le64 CreationTime;
> +	__le64 LastAccessTime;
> +	__le64 LastWriteTime;
> +	__le64 ChangeTime;
> +	__le32 Attributes;
> +	__u32 Pad;
> +} __packed FILE_BASIC_INFO;	/* size info, level 0x101 */
> +