[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <232cbeeb-1a8c-4b09-9e72-50fc544864b1@redhat.com>
Date: Mon, 19 Jan 2026 14:56:46 +0800
From: Gavin Shan <gshan@...hat.com>
To: Catalin Marinas <catalin.marinas@....com>, Ben Horgan <ben.horgan@....com>
Cc: amitsinght@...vell.com, baisheng.gao@...soc.com,
baolin.wang@...ux.alibaba.com, carl@...amperecomputing.com,
dave.martin@....com, david@...nel.org, dfustini@...libre.com,
fenghuay@...dia.com, james.morse@....com, jonathan.cameron@...wei.com,
kobak@...dia.com, lcherian@...vell.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
peternewman@...gle.com, punit.agrawal@....qualcomm.com,
quic_jiles@...cinc.com, reinette.chatre@...el.com, rohit.mathew@....com,
scott@...amperecomputing.com, sdonthineni@...dia.com,
tan.shaopeng@...itsu.com, xhao@...ux.alibaba.com, will@...nel.org,
corbet@....net, maz@...nel.org, oupton@...nel.org, joey.gouly@....com,
suzuki.poulose@....com, kvmarm@...ts.linux.dev
Subject: Re: [PATCH v3 11/47] arm64: mpam: Add helpers to change a task or
cpu's MPAM PARTID/PMG values
On 1/16/26 3:13 AM, Catalin Marinas wrote:
> On Mon, Jan 12, 2026 at 04:58:38PM +0000, Ben Horgan wrote:
>> +static inline void mpam_set_task_partid_pmg(struct task_struct *tsk,
>> + u16 partid_d, u16 partid_i,
>> + u8 pmg_d, u8 pmg_i)
>> +{
>> +#ifdef CONFIG_ARM64_MPAM
>> + u64 regval = __mpam_regval(partid_d, partid_i, pmg_d, pmg_i);
>> +
>> + WRITE_ONCE(task_thread_info(tsk)->mpam_partid_pmg, regval);
>> +#endif
>> +}
>
> Isn't this function, together with mpam_thread_switch(), in an enclosing
> #ifdef already?
>
I think Catalin is correct that this ifdef inside mpam_set_task_partid_pmg()
can be dropped.
>> +
>> static inline void mpam_thread_switch(struct task_struct *tsk)
>> {
>> u64 oldregval;
>> --
>> 2.43.0
>>
Thanks,
Gavin
Powered by blists - more mailing lists