linux-kernel - Re: [PATCH 0/1] platform/x86/amd/pmf: Introduce option to disable Smart PC function in PMF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0533a23-250c-355f-da06-40262a120675@linux.intel.com>
Date: Mon, 19 Jan 2026 12:00:29 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Alexey Zagorodnikov <xglooom@...il.com>
cc: platform-driver-x86@...r.kernel.org, 
    Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
    Hans de Goede <hansg@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/1] platform/x86/amd/pmf: Introduce option to disable
 Smart PC function in PMF

On Sun, 18 Jan 2026, Alexey Zagorodnikov wrote:

No need to repeat "in PMF" in the shortlog (in the Subject) because you 
already have the pmf prefix).

> This patch introduces an option to disable Smart PC function in amd_pmf driver.

This description should be mostly in the patch itself (with some changes, 
I'll explain here).

Also, please avoid phrases that start with "This patch", "This change" 
etc. but use imperative tone.

> Sometimes, the vendor firmware may contain bugs or other unwanted 
> behaviours in the power management domain. 

If there are any symptoms how an user could identify this feature is the 
culprit, please quote/mention them in the changelog so it can be more 
easily found by searches.

> This option allows the user to manually disable Smart PC power 

Don't use vague phrases like this but explicitly tell what "This option" 
option is (according to the patch, you're adding "a module parameter").

> management and fall back to another strategy.

--
 i.

> Alexey Zagorodnikov (1):
>   platform/x86/amd/pmf: Introduce option to disable Smart PC function in
>     PMF
> 
>  drivers/platform/x86/amd/pmf/core.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
>