linux-kernel - Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13000903.O9o76ZdvQC@workhorse>
Date: Tue, 20 Jan 2026 13:57:56 +0100
From: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
To: Sandy Huang <hjc@...k-chips.com>,
 Heiko Stübner <heiko@...ech.de>,
 Andy Yan <andy.yan@...k-chips.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Daniel Stone <daniels@...labora.com>
Subject:
 Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional
 to WARN_ON

On Tuesday, 20 January 2026 13:49:12 Central European Standard Time Thomas Zimmermann wrote:
> Hi
> 
> Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli:
> > From: Daniel Stone <daniels@...labora.com>
> >
> > We should never be able to create a framebuffer with an unsupported
> > format, so throw a warning if this ever happens, instead of attempting
> > to stagger on.
> >
> > Signed-off-by: Daniel Stone <daniels@...labora.com>
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
> > ---
> >   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > index 498df0ce4680..20b49209ddcd 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
> >   		return 0;
> >   
> >   	format = vop2_convert_format(fb->format->format);
> > -	if (format < 0)
> > +	/* We shouldn't be able to create a fb for an unsupported format */
> > +	if (WARN_ON(format < 0))
> 
> Please use drm_WARN_ON() here.

Hi Thomas,


A later revision of this series has already been applied. Feel free
to send such a patch however.


Kind regards,
Nicolas Frattaroli

> 
> Best regards
> Thomas
> 
> >   		return format;
> >   
> >   	/* Co-ordinates have now been clipped */
> >
> 
>