linux-kernel - Re: [PATCH v2 3/8] drm/rockchip: vop2: Fix Esmart test condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <686d24ee-c37d-4983-9984-2bbb4543395f@suse.de>
Date: Tue, 20 Jan 2026 13:58:11 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
 Sandy Huang <hjc@...k-chips.com>, Heiko Stübner
 <heiko@...ech.de>, Andy Yan <andy.yan@...k-chips.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Daniel Stone <daniels@...labora.com>
Subject: Re: [PATCH v2 3/8] drm/rockchip: vop2: Fix Esmart test condition

Hi

Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli:
> From: Daniel Stone <daniels@...labora.com>
>
> If we want to find out if a window is Esmart or not, test for not being
> a cluster window, rather than AFBDC presence.
>
> No functional effect as only cluster windows support AFBC decode.
>
> Signed-off-by: Daniel Stone <daniels@...labora.com>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 81b3eba07095..9d715d7659af 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1230,12 +1230,10 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
>   	 * This is workaround solution for IC design:
>   	 * esmart can't support scale down when src_w % 16 == 1.
>   	 */
> -	if (!(win->data->feature & WIN_FEATURE_AFBDC)) {
> -		if (src_w > dsp_w && (src_w & 0xf) == 1) {
> -			drm_dbg_kms(vop2->drm, "vp%d %s act_w[%d] MODE 16 == 1\n",
> -				    vp->id, win->data->name, src_w);
> -			src_w -= 1;
> -		}
> +	if (!vop2_cluster_window(win) && src_w > dsp_w && (src_w & 1)) {
> +		drm_dbg_kms(vop2->drm, "vp%d %s act_w[%d] MODE 16 == 1\n",
> +			    vp->id, win->data->name, src_w);

Drivers should usually be using drm_dbg(), drm_err(), drm_warn() etc. 
Print functions with _kms postfix are for the DRM helpers. Here and in 
all other patches.

Best regards
Thomas


> +		src_w -= 1;
>   	}
>   
>   	if (afbc_en && src_w % 4) {
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)