linux-kernel - Re: [PATCH] drivers: pwm: replace `kernel::c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=USrGECVS1qMqs+iCKUqvOdfcjA6phAjaF0wfcTkQt_g@mail.gmail.com>
Date: Tue, 20 Jan 2026 11:15:56 -0500
From: Tamir Duberstein <tamird@...nel.org>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: Drew Fustini <fustini@...nel.org>, Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, linux-riscv@...ts.infradead.org, 
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, Michal Wilczynski <m.wilczynski@...sung.com>
Subject: Re: [PATCH] drivers: pwm: replace `kernel::c_str!` with C-Strings

On Tue, Jan 20, 2026 at 3:39 AM Uwe Kleine-König <ukleinek@...nel.org> wrote:
>
> Hello,
>
> On Mon, Dec 22, 2025 at 01:24:46PM +0100, Tamir Duberstein wrote:
> > From: Tamir Duberstein <tamird@...il.com>
> >
> > C-String literals were added in Rust 1.77. Replace instances of
> > `kernel::c_str!` with C-String literals where possible.
> >
> > Signed-off-by: Tamir Duberstein <tamird@...il.com>
>
> Applied to
>
>         https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
>
> as merge window material with the R-b tags by Michal Wilczynski and
> Daniel Almeida.
>
> (Side note, b4 told me:
>
>           ✗ No key: openssh/tamird@...il.com
>
> . It's not clear to me how to verify this signature. My experiments
> include:
>
>         $ b4 kr --show-keys 20251222-cstr-pwm-v1-1-e8916d976f8d@...il.com
>         ---
>         No keys found in the thread.
>
> and looking at
> https://lore.kernel.org/linux-pwm/20251222-cstr-pwm-v1-1-e8916d976f8d@gmail.com/raw
> where I see
>
>         X-Developer-Key: i=tamird@...il.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc
>
> which IIUC isn't enough to verify the next mail signed with the same
> key. Am I missing something? I very appreciate signing your work, but if
> there is no way for me (or anyone else) to verify it, there is no gain.)

Yep, you are right to call this out. My usual setup uses SSH keys for
commit signing, which are not part of the kernel web of trust. I
promise to start signing kernel work with my GPG key soon :)

In the meantime if you trust Github you can verify my signature
against https://github.com/tamird.keys.

Cheers.
Tamir