linux-kernel - Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7d27dc1-05c7-4525-b483-1712e9d497ee@kernel.org>
Date: Tue, 20 Jan 2026 20:40:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marc Olberding <molberding@...dia.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
 Andrew Jeffery <andrew@...econstruct.com.au>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout

On 20/01/2026 20:26, Marc Olberding wrote:
> Add a 128M layout for the BMC flash chip we didn't boot from. Including
> this allows the user to write to each partition on the alternate spi
> chip. This dtsi follows the existing standard of using the same layout
> as non alt version and prepending `alt` to each partition's name.
> 
> Tested by running on target and catting sysfs nodes

You cannot test this patch that way - DTSI is not included by anything.
This probably should be squashed with next one because makes little
benefit on its own,

>     for devdir in /sys/class/mtd/mtd*; do
>          [[ -d $devdir && -r $devdir/name ]] || continue
>          name=$(<"$devdir/name")
>          [[ $name == alt* ]] || continue
> 
>          size=$(<"$devdir/size")
>          offset=0
>          [[ -r $devdir/offset ]] && offset=$(<"$devdir/offset")
> 
>          dev=$(basename "$devdir")
>          printf "%s name=%s offset=0x%X size=0x%X\n" "$dev" "$name" \
>             "$offset" "$size"
>     done
> 
>     mtd10 name=alt-rofs offset=0xA00000 size=0x5600000
>     mtd11 name=alt-rwfs offset=0x6000000 size=0x2000000
>     mtd7 name=alt-u-boot offset=0x0 size=0xE0000
>     mtd8 name=alt-u-boot-env offset=0xE0000 size=0x20000
>     mtd9 name=alt-kernel offset=0x100000 size=0x900000
> 
> Ran dtbs check, no errors from the msx4 dts

Drop this sentence, it's implied. There is no point to state obvious,
e.g. that you build source code, in the commit msg. It serves no purpose
in the git history. You also have changelog for such things, if you want
to emphasize.

> 
> running diff between the main and alt flash layouts shows that the only
> diff is alt prepended to the partition labels, as expected.

? Not sure what you want to say, but please do not explain us how DTS
works (in case this was about DTS).


Best regards,
Krzysztof