linux-kernel - Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW/l0LbCbfxvwXZz@molberding.nvidia.com>
Date: Tue, 20 Jan 2026 12:30:08 -0800
From: Marc Olberding <molberding@...dia.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout

On Tue, Jan 20, 2026 at 08:40:29PM +0100, Krzysztof Kozlowski wrote:
> On 20/01/2026 20:26, Marc Olberding wrote:
> You cannot test this patch that way - DTSI is not included by anything.
> This probably should be squashed with next one because makes little
> benefit on its own,
Ack, will do in the next patch series.

> > 
> > Ran dtbs check, no errors from the msx4 dts
> 
> Drop this sentence, it's implied. There is no point to state obvious,
> e.g. that you build source code, in the commit msg. It serves no purpose
> in the git history. You also have changelog for such things, if you want
> to emphasize.
ack, will drop.
> > 
> > running diff between the main and alt flash layouts shows that the only
> > diff is alt prepended to the partition labels, as expected.
> 
> ? Not sure what you want to say, but please do not explain us how DTS
> works (in case this was about DTS).

I'll drop this piece. This was a recommended piece of testing by Andrew,
the maintainer, just to show that the alt partition and main partition files
are only different by the label names. That said, its redundant with the testing
on target shown above.

Thanks for your feedback
Marc