linux-kernel - Re: [PATCH v13 11/12] x509, pkcs7: Limit crypto combinations that may be used for module signing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1417088.1768951131@warthog.procyon.org.uk>
Date: Tue, 20 Jan 2026 23:18:51 +0000
From: David Howells <dhowells@...hat.com>
To: Vitaly Chikunov <vt@...linux.org>
Cc: dhowells@...hat.com, Lukas Wunner <lukas@...ner.de>,
    Ignat Korchagin <ignat@...udflare.com>,
    Jarkko Sakkinen <jarkko@...nel.org>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Eric Biggers <ebiggers@...nel.org>,
    Luis Chamberlain <mcgrof@...nel.org>,
    Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>,
    Sami Tolvanen <samitolvanen@...gle.com>,
    "Jason
 A . Donenfeld" <Jason@...c4.com>,
    Ard Biesheuvel <ardb@...nel.org>,
    Stephan Mueller <smueller@...onox.de>, linux-crypto@...r.kernel.org,
    keyrings@...r.kernel.org, linux-modules@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 11/12] x509, pkcs7: Limit crypto combinations that may be used for module signing

Vitaly Chikunov <vt@...linux.org> wrote:

> > +static const struct public_key_restriction public_key_restrictions[] = {
> > +	/* algo			encoding	hash */
> > +	{ "rsa",		"pkcs1",	"sha256" },
> > +	{ "rsa",		"pkcs1",	"sha384" },
> > +	{ "rsa",		"pkcs1",	"sha512" },
> > +	{ "rsa",		"emsa-pss",	"sha512" },
> > +	{ "ecdsa",		"x962",		"sha256" },
> > +	{ "ecdsa",		"x962",		"sha384" },
> > +	{ "ecdsa",		"x962",		"sha512" },
> > +	{ "ecrdsa",		"raw",		"sha256" },
> > +	{ "ecrdsa",		"raw",		"sha384" },
> > +	{ "ecrdsa",		"raw",		"sha512" },
> 
> Why such hash choice? Aren't it should be streebog256 and streebog512?

Maybe?  I don't have any example ecrdsa (assuming you're talking about that
specifically), nor does it seem that it was added to the choice of module
signing.  Possibly I should drop the encoding column - or just have a list of
hashes that we accept - but we might want to limit the hashes that can use
with ML-DSA more strictly (ie. only allow SHA512).

David