linux-kernel - RE: [PATCH v2 net-next 12/14] net: fec: add fec_alloc_rxq_buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85100C9767C30722D693BCFE8889A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 20 Jan 2026 07:30:13 +0000
From: Wei Fang <wei.fang@....com>
To: Frank Li <frank.li@....com>
CC: Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net"
	<daniel@...earbox.net>, "hawk@...nel.org" <hawk@...nel.org>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "sdf@...ichev.me"
	<sdf@...ichev.me>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 12/14] net: fec: add
 fec_alloc_rxq_buffers_pp() to allocate buffers from page pool

> > fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int
> > queue)
> >
> >  		if (fep->bufdesc_ex) {
> >  			struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
> > +
> 
> uneccesary change

This might be a problem with how git displays it, the actual change is
in fec_alloc_rxq_buffers_pp(), as shown below. We need to add a
blank after the variable definition.

if (fep->bufdesc_ex) {
			struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;

			ebdp->cbd_esc = cpu_to_fec32(BD_ENET_RX_INT);
}