Message-ID: <24e308b019cf9272884091f85b6675fd05201a2b.camel@redhat.com>
Date: Tue, 20 Jan 2026 08:33:10 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>, Nam Cao <namcao@...utronix.de>
Cc: Steven Rostedt <rostedt@...dmis.org>, open list
	 <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION (RV)"
	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/26] rv/rvgen: introduce AutomataError exception class

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> Replace generic Exception usage with a custom AutomataError class
> that inherits from OSError throughout the rvgen tool. This change
> provides more precise exception handling for automata parsing and
> validation errors while avoiding overly broad exception catches that
> could mask programming errors like SyntaxError or TypeError.
> 
> The AutomataError class inherits from OSError rather than Exception
> because most error conditions involve file I/O operations such as
> reading DOT files or handling file access issues. This semantic
> alignment makes exception handling more specific and appropriate.
> The exception is raised when DOT file processing fails due to invalid
> format, I/O errors, or malformed automaton definitions.
> 
> Additionally, remove the broad try-except block from __main__.py that
> was catching all exceptions. This allows Python's default exception
> handling to provide complete stack traces, making debugging
> significantly easier by showing exact error types and locations.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Thanks for the extensive series!
See my comments below.
Mind that I likely know python less than you do, so just call me out when I
start babbling.

> ---
>  tools/verification/rvgen/__main__.py        | 25 +++++++++------------
>  tools/verification/rvgen/rvgen/automata.py  | 17 +++++++++-----
>  tools/verification/rvgen/rvgen/dot2c.py     |  4 ++--
>  tools/verification/rvgen/rvgen/generator.py |  7 ++----
>  4 files changed, 26 insertions(+), 27 deletions(-)
> 
> diff --git a/tools/verification/rvgen/__main__.py
> b/tools/verification/rvgen/__main__.py
> index fa6fc1f4de2f7..768b11a1e978b 100644
> --- a/tools/verification/rvgen/__main__.py
> +++ b/tools/verification/rvgen/__main__.py
> @@ -39,22 +39,17 @@ if __name__ == '__main__':
>  
>      params = parser.parse_args()
>  
> -    try:
> -        if params.subcmd == "monitor":
> -            print("Opening and parsing the specification file %s" %
> params.spec)
> -            if params.monitor_class == "da":
> -                monitor = dot2k(params.spec, params.monitor_type,
> vars(params))
> -            elif params.monitor_class == "ltl":
> -                monitor = ltl2k(params.spec, params.monitor_type,
> vars(params))
> -            else:
> -                print("Unknown monitor class:", params.monitor_class)
> -                sys.exit(1)
> +    if params.subcmd == "monitor":
> +        print("Opening and parsing the specification file %s" % params.spec)
> +        if params.monitor_class == "da":
> +            monitor = dot2k(params.spec, params.monitor_type, vars(params))
> +        elif params.monitor_class == "ltl":
> +            monitor = ltl2k(params.spec, params.monitor_type, vars(params))
>          else:
> -            monitor = Container(vars(params))
> -    except Exception as e:
> -        print('Error: '+ str(e))
> -        print("Sorry : :-(")
> -        sys.exit(1)
> +            print("Unknown monitor class:", params.monitor_class)
> +            sys.exit(1)
> +    else:
> +        monitor = Container(vars(params))
>  

I agree catching all exceptions like this is quite detrimental while debugging,
but I see the original intent.
When you run commands written in python, you normally don't expect them to blurt
a stack trace when doing relatively normal things, like opening a wrong file.
Sure that might be useful when debugging, but for a user-facing tool we want to
write a meaningful error message and gracefully fail.

Other story is when the exception is something unexpected (that's why leaving a
generic Exception here is bad).

>      print("Writing the monitor into the directory %s" % monitor.name)
>      monitor.print_files()
> diff --git a/tools/verification/rvgen/rvgen/automata.py
> b/tools/verification/rvgen/rvgen/automata.py
> index d9a3fe2b74bf2..8d88c3b65d00d 100644
> --- a/tools/verification/rvgen/rvgen/automata.py
> +++ b/tools/verification/rvgen/rvgen/automata.py
> @@ -10,6 +10,13 @@
>  
>  import ntpath
>  
> +class AutomataError(OSError):
> +    """Exception raised for errors in automata parsing and validation.
> +
> +    Raised when DOT file processing fails due to invalid format, I/O errors,
> +    or malformed automaton definitions.
> +    """
> +

I'm not quite familiar with modern python best practices (so again, take my
comments with a grain of salt ;) ), but what is the advantage of using this
custom exception instead of using pre-existing specific exception types?

Although the difference is minimal, here you're throwing an OSError for
something that quite isn't (e.g. wrong format for the dot file).
A ValueError feels more appropriate to me in most of the instances here.

All in all, I would do something like:
* throw a ValueError (or a custom one based on that) whenever we expect wrong
data not dependent on OS features
* throw OSError whenever that was the exception, perhaps changing the message to
something more meaningful to us (like you're already doing here)
* intercept only those errors in main.py and print the message without stack
trace (if the message is clear enough we shouldn't need it).

Does it make sense to you?

Thanks,
Gabriele

>  class Automata:
>      """Automata class: Reads a dot file and part it as an automata.
>  
> @@ -32,11 +39,11 @@ class Automata:
>          basename = ntpath.basename(self.__dot_path)
>          if not basename.endswith(".dot") and not basename.endswith(".gv"):
>              print("not a dot file")
> -            raise Exception("not a dot file: %s" % self.__dot_path)
> +            raise AutomataError("not a dot file: %s" % self.__dot_path)
>  
>          model_name = ntpath.splitext(basename)[0]
>          if model_name.__len__() == 0:
> -            raise Exception("not a dot file: %s" % self.__dot_path)
> +            raise AutomataError("not a dot file: %s" % self.__dot_path)
>  
>          return model_name
>  
> @@ -45,8 +52,8 @@ class Automata:
>          dot_lines = []
>          try:
>              dot_file = open(self.__dot_path)
> -        except:
> -            raise Exception("Cannot open the file: %s" % self.__dot_path)
> +        except OSError as exc:
> +            raise AutomataError(f"Cannot open the file: {self.__dot_path}")
> from exc
>  
>          dot_lines = dot_file.read().splitlines()
>          dot_file.close()
> @@ -55,7 +62,7 @@ class Automata:
>          line = dot_lines[cursor].split()
>  
>          if (line[0] != "digraph") and (line[1] != "state_automaton"):
> -            raise Exception("Not a valid .dot format: %s" % self.__dot_path)
> +            raise AutomataError("Not a valid .dot format: %s" %
> self.__dot_path)
>          else:
>              cursor += 1
>          return dot_lines
> diff --git a/tools/verification/rvgen/rvgen/dot2c.py
> b/tools/verification/rvgen/rvgen/dot2c.py
> index b9b6f14cc536a..1a1770e7f20c0 100644
> --- a/tools/verification/rvgen/rvgen/dot2c.py
> +++ b/tools/verification/rvgen/rvgen/dot2c.py
> @@ -13,7 +13,7 @@
>  # For further information, see:
>  #   Documentation/trace/rv/deterministic_automata.rst
>  
> -from .automata import Automata
> +from .automata import Automata, AutomataError
>  
>  class Dot2c(Automata):
>      enum_suffix = ""
> @@ -93,7 +93,7 @@ class Dot2c(Automata):
>              min_type = "unsigned int"
>  
>          if self.states.__len__() > 1000000:
> -            raise Exception("Too many states: %d" % self.states.__len__())
> +            raise AutomataError("Too many states: %d" %
> self.states.__len__())
>  
>          return min_type
>  
> diff --git a/tools/verification/rvgen/rvgen/generator.py
> b/tools/verification/rvgen/rvgen/generator.py
> index 3441385c11770..a7bee6b1ea70c 100644
> --- a/tools/verification/rvgen/rvgen/generator.py
> +++ b/tools/verification/rvgen/rvgen/generator.py
> @@ -51,10 +51,7 @@ class RVGenerator:
>          raise FileNotFoundError("Could not find the rv directory, do you have
> the kernel source installed?")
>  
>      def _read_file(self, path):
> -        try:
> -            fd = open(path, 'r')
> -        except OSError:
> -            raise Exception("Cannot open the file: %s" % path)
> +        fd = open(path, 'r')
>  
>          content = fd.read()
>  
> @@ -65,7 +62,7 @@ class RVGenerator:
>          try:
>              path = os.path.join(self.abs_template_dir, file)
>              return self._read_file(path)
> -        except Exception:
> +        except OSError:
>              # Specific template file not found. Try the generic template file
> in the template/
>              # directory, which is one level up
>              path = os.path.join(self.abs_template_dir, "..", file)

Powered by blists - more mailing lists