linux-kernel - Re: [PATCH 05/26] rv/rvgen: remove unnecessary semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3278263b3df8ced3816b5206f9c350d8c18f7ce5.camel@redhat.com>
Date: Tue, 20 Jan 2026 08:42:53 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>, Steven Rostedt
	 <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, open list
	 <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION (RV)"
	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/26] rv/rvgen: remove unnecessary semicolons

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> Remove unnecessary semicolons from Python code in the rvgen tool.
> Python does not require semicolons to terminate statements, and
> their presence goes against PEP 8 style guidelines. These semicolons
> were likely added out of habit from C-style languages.
> 
> The changes affect four instances across two files. In dot2c.py, one
> semicolon is removed from a boolean assignment. In dot2k.py, three
> semicolons are removed from string append operations that build
> generated C code. Note that the semicolons inside the string literals
> themselves are correctly preserved as they are part of the C code
> being generated, not Python syntax.
> 
> This cleanup improves consistency with Python coding standards and
> aligns with the recent improvements to remove other Python
> anti-patterns from the codebase.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Muscle memory is hard to control. Thanks!

Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>

> ---
>  tools/verification/rvgen/rvgen/dot2c.py | 2 +-
>  tools/verification/rvgen/rvgen/dot2k.py | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/verification/rvgen/rvgen/dot2c.py
> b/tools/verification/rvgen/rvgen/dot2c.py
> index 0fb3617ad8ce9..b9a2c009a9246 100644
> --- a/tools/verification/rvgen/rvgen/dot2c.py
> +++ b/tools/verification/rvgen/rvgen/dot2c.py
> @@ -120,7 +120,7 @@ class Dot2c(Automata):
>          for entry in buff:
>              if first:
>                  string = string + "\t\t\"" + entry
> -                first = False;
> +                first = False
>              else:
>                  string = string + "\",\n\t\t\"" + entry
>          string = string + "\""
> diff --git a/tools/verification/rvgen/rvgen/dot2k.py
> b/tools/verification/rvgen/rvgen/dot2k.py
> index 1c0d0235bdf62..291385adb2c20 100644
> --- a/tools/verification/rvgen/rvgen/dot2k.py
> +++ b/tools/verification/rvgen/rvgen/dot2k.py
> @@ -37,10 +37,10 @@ class dot2k(Monitor, Dot2c):
>                  buff.append("\t/* XXX: validate that this event is only valid
> in the initial state */")
>                  handle = "handle_start_run_event"
>              if self.monitor_type == "per_task":
> -                buff.append("\tstruct task_struct *p = /* XXX: how do I get
> p? */;");
> -                buff.append(f"\tda_{handle}_{self.name}(p,
> {event}{self.enum_suffix});");
> +                buff.append("\tstruct task_struct *p = /* XXX: how do I get
> p? */;")
> +                buff.append(f"\tda_{handle}_{self.name}(p,
> {event}{self.enum_suffix});")
>              else:
> -               
> buff.append(f"\tda_{handle}_{self.name}({event}{self.enum_suffix});");
> +               
> buff.append(f"\tda_{handle}_{self.name}({event}{self.enum_suffix});")
>              buff.append("}")
>              buff.append("")
>          return '\n'.join(buff)