linux-kernel - Re: [PATCH] mm/pagewalk: use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc9a831a-f677-46c9-a876-6e313f2094a3@lucifer.local>
Date: Tue, 20 Jan 2026 10:41:56 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: zenghongling <zenghongling@...inos.cn>
Cc: akpm@...ux-foundation.org, david@...nel.org, Liam.Howlett@...cle.com,
        vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        zhongling0719@....com
Subject: Re: [PATCH] mm/pagewalk: use min() to simplify the code

On Tue, Jan 20, 2026 at 05:49:32PM +0800, zenghongling wrote:
> Use the min() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: zenghongling <zenghongling@...inos.cn>

LGTM, other than nit below (Andrew, maybe you can insert a newline there?) so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

> ---
>  mm/pagewalk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
>  				       unsigned long end)
>  {
>  	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);

Nit: Ideally we'd introduce a space between decl and statement below.

> -	return boundary < end ? boundary : end;
> +	return min(boundary, end);
>  }
>
>  static int walk_hugetlb_range(unsigned long addr, unsigned long end,
> --
> 2.25.1
>