linux-kernel - Re: [PATCH] mm/pagewalk: use min() to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39f4490a-d713-44a8-a1d7-3568b01b3dc2@kernel.org>
Date: Wed, 21 Jan 2026 13:05:36 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: zenghongling <zenghongling@...inos.cn>, akpm@...ux-foundation.org,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 rppt@...nel.org, surenb@...gle.com, mhocko@...e.com
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, zhongling0719@....com,
 Sahil Chandna <chandna.sahil@...il.com>
Subject: Re: [PATCH] mm/pagewalk: use min() to simplify the code

On 1/20/26 10:49, zenghongling wrote:
> Use the min() macro to simplify the function and improve
> its readability.
> 
> Signed-off-by: zenghongling <zenghongling@...inos.cn>
> ---
>   mm/pagewalk.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
>   				       unsigned long end)
>   {
>   	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
> -	return boundary < end ? boundary : end;
> +	return min(boundary, end);

There was a length discussion recently about changing this code:

https://lore.kernel.org/linux-mm/35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com/

Changing the min only LGTM.

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David