linux-kernel - Re: [PATCH 19/26] rv/rvgen: add abstract method stubs to Container class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69298b5dcfda02051c5c1fe995efc333f980664f.camel@redhat.com>
Date: Wed, 21 Jan 2026 14:59:09 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, 
 open list <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION
 (RV)"	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/26] rv/rvgen: add abstract method stubs to Container
 class

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> The Container class extends RVGenerator but was missing implementations
> for several abstract methods decorated with @not_implemented in the base
> class. This could lead to NotImplementedError exceptions if code paths
> attempt to call these methods on Container instances.
> 
> Add empty-string returning stub implementations for
> fill_tracepoint_handlers_skel,
> fill_tracepoint_attach_probe, fill_tracepoint_detach_helper, and
> fill_monitor_class_type. These empty returns are semantically correct
> since Container is a grouping mechanism for organizing monitors, not an
> actual monitor that generates tracepoint-specific C code.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>
> ---

Just like the previous patch, the NotImplementedError here highlights a weakness
in the design we should improve instead of cover.
If all those fillers don't make sense for containers, we should instead move
them to Monitor and leave RVGenerator alone.

Thanks,
Gabriele

>  tools/verification/rvgen/rvgen/container.py | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tools/verification/rvgen/rvgen/container.py
> b/tools/verification/rvgen/rvgen/container.py
> index 51f188530b4dd..65df21dfd17b2 100644
> --- a/tools/verification/rvgen/rvgen/container.py
> +++ b/tools/verification/rvgen/rvgen/container.py
> @@ -30,3 +30,15 @@ class Container(generator.RVGenerator):
>                               self._kconfig_marker(), container_marker)
>              return result
>          return result + container_marker
> +
> +    def fill_tracepoint_handlers_skel(self) -> str:
> +        return ""
> +
> +    def fill_tracepoint_attach_probe(self) -> str:
> +        return ""
> +
> +    def fill_tracepoint_detach_helper(self) -> str:
> +        return ""
> +
> +    def fill_monitor_class_type(self) -> str:
> +        return ""