linux-kernel - Re: [PATCH 18/26] rv/rvgen: add fill_tracepoint_args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f168ff5ffb531570fd83e3f398380e8df053275.camel@redhat.com>
Date: Wed, 21 Jan 2026 14:57:02 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>, Steven Rostedt
	 <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, open list
	 <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION (RV)"
	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 18/26] rv/rvgen: add fill_tracepoint_args_skel stub to
 ltl2k

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> The ltl2k class inherits from Monitor which requires subclasses to
> implement fill_tracepoint_args_skel(). However, the ltl2k template
> uses hardcoded tracepoint arguments rather than the placeholders that
> this method would fill. The base class fill_trace_h() method calls
> fill_tracepoint_args_skel() unconditionally, which was exposed when
> the @not_implemented decorator was introduced.
> 
> Add a stub implementation that returns an empty string. Since the
> ltl2k trace.h template does not contain the placeholder strings that
> would be replaced, the empty return value has no effect on the
> generated output while satisfying the base class interface contract.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Mmh, this is a bit fishy though.
We the patch using the decorator seems fine, but highlights how this method
isn't meant to be in Monitor if not all monitors use it..
Adding a stub here is just sweeping dust under the carpet.

Here should probably keep the common part of fill_trace_h() in Monitor (e.g.
replacing MODEL_NAME and other common things) and create specific
implementations in dot2k and ltl2k for what is not common while calling the
super() counterpart for the rest.

Does it make sense to you?

Thanks,
Gabriele

> ---
>  tools/verification/rvgen/rvgen/ltl2k.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/verification/rvgen/rvgen/ltl2k.py
> b/tools/verification/rvgen/rvgen/ltl2k.py
> index 94dc64af1716d..f1eafc16c754b 100644
> --- a/tools/verification/rvgen/rvgen/ltl2k.py
> +++ b/tools/verification/rvgen/rvgen/ltl2k.py
> @@ -257,6 +257,9 @@ class ltl2k(generator.Monitor):
>  
>          return '\n'.join(buf)
>  
> +    def fill_tracepoint_args_skel(self, tp_type) -> str:
> +        return ""
> +
>      def fill_monitor_class_type(self):
>          return "LTL_MON_EVENTS_ID"
>