[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260121155245.GG166857@noisy.programming.kicks-ass.net>
Date: Wed, 21 Jan 2026 16:52:45 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Andrea Righi <arighi@...dia.com>
Cc: Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
Joel Fernandes <joelagnelf@...dia.com>, Tejun Heo <tj@...nel.org>,
David Vernet <void@...ifault.com>,
Changwoo Min <changwoo@...lia.com>, Shuah Khan <shuah@...nel.org>,
sched-ext@...ts.linux.dev, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org,
Christian Loehle <christian.loehle@....com>
Subject: Re: [PATCH 4/7] sched_ext: Add a DL server for sched_ext tasks
On Wed, Jan 21, 2026 at 01:49:38PM +0100, Andrea Righi wrote:
> On Wed, Jan 21, 2026 at 01:29:01PM +0100, Peter Zijlstra wrote:
> > On Tue, Jan 20, 2026 at 10:50:35PM +0100, Andrea Righi wrote:
> >
> > > @@ -1813,6 +1813,7 @@ void dl_server_stop(struct sched_dl_entity *dl_se)
> > > hrtimer_try_to_cancel(&dl_se->dl_timer);
> > > dl_se->dl_defer_armed = 0;
> > > dl_se->dl_throttled = 0;
> > > + dl_se->dl_defer_running = 0;
> > > dl_se->dl_defer_idle = 0;
> > > dl_se->dl_server_active = 0;
> > > }
> >
> > This should definitely not be in this patch. Why was this added? Were
> > you trying to do the same as:
> >
> > ca1e8eede4fc ("sched/deadline: Fix server stopping with runnable tasks")
> >
>
> The problem is that if remove this, RT can completely stall EXT tasks, also
> with ca1e8eede4fc applied.
But that's not something ext specific, right? Can you pull this change
out and write a sane Changelog for it, describing the problem and so?
Powered by blists - more mailing lists