[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aXDLzlvzV-dfer7R@gpd4>
Date: Wed, 21 Jan 2026 13:51:26 +0100
From: Andrea Righi <arighi@...dia.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
Joel Fernandes <joelagnelf@...dia.com>, Tejun Heo <tj@...nel.org>,
David Vernet <void@...ifault.com>,
Changwoo Min <changwoo@...lia.com>, Shuah Khan <shuah@...nel.org>,
sched-ext@...ts.linux.dev, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org,
Christian Loehle <christian.loehle@....com>
Subject: Re: [PATCH 4/7] sched_ext: Add a DL server for sched_ext tasks
On Wed, Jan 21, 2026 at 01:31:58PM +0100, Peter Zijlstra wrote:
...
> > v5: - do not restart the EXT server on switch_class() (Juri Lelli)
> > v4: - initialize EXT server bandwidth reservation at init time and
> > always keep it active (Andrea Righi)
> > - check for rq->nr_running == 1 to determine when to account idle
> > time (Juri Lelli)
> > v3: - clarify that fair is not the only dl_server (Juri Lelli)
> > - remove explicit stop to reduce timer reprogramming overhead
> > (Juri Lelli)
> > - do not restart pick_task() when it's invoked by the dl_server
> > (Tejun Heo)
> > - depend on CONFIG_SCHED_CLASS_EXT (Andrea Righi)
> > v2: - drop ->balance() now that pick_task() has an rf argument
> > (Andrea Righi)
>
> FWIW (for all these patches), those v# comments, they go...
>
> > Reviewed-by: Juri Lelli <juri.lelli@...hat.com>
> > Tested-by: Christian Loehle <christian.loehle@....com>
> > Co-developed-by: Joel Fernandes <joelagnelf@...dia.com>
> > Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
> > Signed-off-by: Andrea Righi <arighi@...dia.com>
> > ---
>
> ... here, after the ---.
Oh... I used to do it this way, then noticed others were including the
version in the patch and I started doing the same, I’ll revert to my
original way. :)
Thanks,
-Andrea
Powered by blists - more mailing lists