linux-kernel - Re: [PATCH v4 2/2] arm64: dts: rockchip: Add rk3576 evb2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9cf22c2-a41d-464e-b6cb-ec36149aeb50@rock-chips.com>
Date: Wed, 21 Jan 2026 10:29:14 +0800
From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
To: Shawn Lin <shawn.lin@...k-chips.com>
Cc: Chaoyi Chen <kernel@...kyi.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Quentin Schulz <quentin.schulz@...rry.de>, Jonas Karlman <jonas@...boo.se>,
 Hsun Lai <i@...insx.cn>, John Clark <inindev@...il.com>,
 Jimmy Hon <honyuenkwun@...il.com>, Dragan Simic <dsimic@...jaro.org>,
 Michael Riesch <michael.riesch@...labora.com>,
 Peter Robinson <pbrobinson@...il.com>, Alexey Charkov <alchark@...il.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Andy Yan <andy.yan@...k-chips.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add rk3576 evb2 board

Hi Shawn,

On 1/21/2026 10:09 AM, Shawn Lin wrote:
> 在 2026/01/21 星期三 9:53, Chaoyi Chen 写道:
>> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>>
>> General features for rk3576 evb2 board:
>>      - Rockchip RK3576
>>      - LPDDR4/4X
>>      - eMMC5.1
>>      - RK806-2x2pcs + DiscretePower
>>      - 1x HDMI2.1 TX / HDMI2.0 RX
>>      - 1x full size DP1.4 TX (Only 2 Lanes)
>>      - 2x 10/100/1000M Ethernet
>>      - 5x SATA3.0 7Pin Slot
>>      - 2x USB3.2 Gen1 Host
>>      - 3x USB2.0 Host
>>      - WIFI/BT
>>      - ...
>>
>> Tested with eMMC/SDMMC/HDMI/USB/Ethernet/WIFI/BT module.
>>
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>> Reviewed-by: Alexey Charkov <alchark@...il.com>
>> ---
> 
> ---8<----
> 
>> +
>> +&sdio {
>> +    #address-cells = <1>;
>> +    #size-cells = <0>;
>> +    bus-width = <4>;
>> +    cap-sd-highspeed;
>> +    cap-sdio-irq;
>> +    disable-wp;
> 
> disable-wp is not used for SDIO case, could be removed.
> 
> 

Will fix in v5.

>> +    keep-power-in-suspend;
>> +    max-frequency = <150000000>;
>> +    mmc-pwrseq = <&sdio_pwrseq>;
>> +    no-sd;
>> +    no-mmc;
>> +    non-removable;
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&sdmmc1m0_bus4 &sdmmc1m0_clk &sdmmc1m0_cmd>;
>> +    sd-uhs-sdr104;
>> +    status = "okay";
>> +
>> +    brcmf: wifi@1 {
>> +        compatible = "brcm,bcm4329-fmac";
>> +        reg = <1>;
>> +        interrupt-parent = <&gpio0>;
>> +        interrupts = <RK_PB0 IRQ_TYPE_LEVEL_HIGH>;
>> +        interrupt-names = "host-wake";
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&wifi_host_wake>;
>> +    };
>> +};
>> +
>> +&sdhci {
>> +    bus-width = <8>;
>> +    full-pwr-cycle-in-suspend;
>> +    mmc-hs400-1_8v;
>> +    mmc-hs400-enhanced-strobe;
>> +    no-sdio;
>> +    no-sd;
>> +    non-removable;
>> +    status = "okay";
>> +};
>> +
>> +&sdmmc {
>> +    bus-width = <4>;
>> +    cap-sd-highspeed;
>> +    cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
>> +    disable-wp;
>> +    no-sdio;
>> +    no-mmc;
>> +    sd-uhs-sdr104;
>> +    vqmmc-supply = <&vccio_sd_s0>;
> 
> Should use vmmc-supply to contrl the power, the same as EVB1[1].
> 
> [1] https://lore.kernel.org/linux-rockchip/1768524932-163929-5-git-send-email-shawn.lin@rock-chips.com/T/#u
> 

That make sense. Will fix in v5.

>> +    status = "okay";
>> +};
>> +
>> +&u2phy0 {
>> +    status = "okay";
>> +};
>> +
> 
> 
> 
> 

-- 
Best, 
Chaoyi