linux-kernel - Re: [PATCH v2 01/13] spi: dt-bindings: cdns,qspi-nor: Add Renesas RZ/N1D400 to the list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121024002.GA1845406-robh@kernel.org>
Date: Tue, 20 Jan 2026 20:40:02 -0600
From: Rob Herring <robh@...nel.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Vaishnav Achath <vaishnav.a@...com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Hervé Codina <herve.codina@...tlin.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Vignesh Raghavendra <vigneshr@...com>,
	Santhosh Kumar K <s-k6@...com>,
	Pratyush Yadav <pratyush@...nel.org>,
	Pascal Eberhard <pascal.eberhard@...com>, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 01/13] spi: dt-bindings: cdns,qspi-nor: Add Renesas
 RZ/N1D400 to the list

On Fri, Jan 16, 2026 at 10:39:21AM +0100, Miquel Raynal wrote:
> Hello Geert,
> 
> >> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> >> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> >> @@ -80,6 +80,10 @@ properties:
> >>            # controllers are meant to be used with flashes of all kinds,
> >>            # ie. also NAND flashes, not only NOR flashes.
> >>            - const: cdns,qspi-nor
> >> +      - items:
> >> +          - const: renesas,r9a06g032-qspi
> >> +          - const: renesas,rzn1-qspi
> >> +          - const: cdns,qspi-nor
> >
> > Doesn't the need for (at least) the CQSPI_NO_INDIRECT_MODE flag mean
> > that this device is not compatible with cdns,qspi-nor, and thus the
> > cdns,qspi-nor fallback must not be used?
> 
> I understand the question. It is true that I use driver data to limit
> the number of features the IP can use and this data is associated to the
> Renesas compatible, but I believe all other flavours of this IP would
> also not work without driver data attached to their front
> compatible. None of the SoCs with the Cadence QSPI IP actually would run
> without their own driver data. For me the fallback compatible is
> relevant because it describes the hardware as "this is a derivative of
> the Cadence controller" (and it is clearly the case, and this is also
> mentioned in the reference manual), even though I agree using
> cdns,qspi-nor would definitely not work alone. But again, none of the
> other flavours would anyway.

Fallbacks should be usable on their own. We've generally moved away from 
having these generic licensed IP compatibles because they always have 
per platform changes.

Rob